Fix a crach when editing a bookmark in the bookmarks drawer. https://redmine.stoutne...
authorSoren Stoutner <soren@stoutner.com>
Wed, 8 Nov 2017 22:30:24 +0000 (15:30 -0700)
committerSoren Stoutner <soren@stoutner.com>
Wed, 8 Nov 2017 22:30:24 +0000 (15:30 -0700)
20 files changed:
app/src/main/assets/de/about_changelog_dark.html
app/src/main/assets/de/about_changelog_light.html
app/src/main/assets/en/about_changelog_dark.html
app/src/main/assets/en/about_changelog_light.html
app/src/main/assets/es/about_changelog_dark.html
app/src/main/assets/es/about_changelog_light.html
app/src/main/assets/it/about_changelog_dark.html
app/src/main/assets/it/about_changelog_light.html
app/src/main/res/color/bookmarks_spinner_color_selector_dark.xml
app/src/main/res/color/edit_bookmark_spinner_color_selector_dark.xml
app/src/main/res/layout/domain_settings_fragment.xml
app/src/main/res/layout/domain_settings_spinner_dropdown_item.xml
app/src/main/res/layout/domain_settings_spinner_item.xml
app/src/main/res/layout/edit_bookmark_databaseview_dialog.xml
app/src/main/res/layout/edit_bookmark_databaseview_spinner_item.xml
app/src/main/res/layout/edit_bookmark_dialog.xml
app/src/main/res/layout/edit_bookmark_folder_databaseview_dialog.xml
app/src/main/res/layout/edit_bookmark_folder_dialog.xml
app/src/main/res/values/attrs.xml
app/src/main/res/values/styles.xml

index 40340c7..115101b 100644 (file)
@@ -30,7 +30,7 @@
 
     <body>
         <h3>2.7 (version code 27)</h3>
-        <p>7. November 2017 - minimum API 19, target API 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7. November 2017</a> - minimum API 19, target API 26</p>
         <ul>
             <li>Add a <a href="https://redmine.stoutner.com/issues/132">bookmarks drawer</a> that is accessed by sliding from the right.</li>
             <li>Prevent Night Mode from <a href="https://redmine.stoutner.com/issues/213">flashing a white background</a> when loading new pages.</li>
index 7c66156..4ab95ad 100644 (file)
@@ -30,7 +30,7 @@
 
     <body>
         <h3>2.7 (version code 27)</h3>
-        <p>7. November 2017 - minimum API 19, target API 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7. November 2017</a> - minimum API 19, target API 26</p>
         <ul>
             <li>Add a <a href="https://redmine.stoutner.com/issues/132">bookmarks drawer</a> that is accessed by sliding from the right.</li>
             <li>Prevent Night Mode from <a href="https://redmine.stoutner.com/issues/213">flashing a white background</a> when loading new pages.</li>
index 75f1c2c..270f283 100644 (file)
@@ -25,7 +25,7 @@
 
     <body>
         <h3>2.7 (version code 27)</h3>
-        <p>7 November 2017 - minimum API 19, target API 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7 November 2017</a> - minimum API 19, target API 26</p>
         <ul>
             <li>Add a <a href="https://redmine.stoutner.com/issues/132">bookmarks drawer</a> that is accessed by sliding from the right.</li>
             <li>Prevent Night Mode from <a href="https://redmine.stoutner.com/issues/213">flashing a white background</a> when loading new pages.</li>
index 717622b..13d64bf 100644 (file)
@@ -25,7 +25,7 @@
 
     <body>
         <h3>2.7 (version code 27)</h3>
-        <p>7 November 2017 - minimum API 19, target API 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7 November 2017</a> - minimum API 19, target API 26</p>
         <ul>
             <li>Add a <a href="https://redmine.stoutner.com/issues/132">bookmarks drawer</a> that is accessed by sliding from the right.</li>
             <li>Prevent Night Mode from <a href="https://redmine.stoutner.com/issues/213">flashing a white background</a> when loading new pages.</li>
index 57fbceb..ee72311 100644 (file)
@@ -27,7 +27,7 @@
 
     <body>
         <h3>2.7 (código de versión 27)</h3>
-        <p>7 de noviembre de 2017 - API mínimo 19, API dirigido 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7 de noviembre de 2017</a> - API mínimo 19, API dirigido 26</p>
         <ul>
             <li>Añadir un <a href="https://redmine.stoutner.com/issues/132">cajón de favoritos</a> al que se accede deslizando desde la derecha.</li>
             <li>Evitar que el Modo Noche <a href="https://redmine.stoutner.com/issues/213">parpadee sobre un fondo blanco</a> al cargar páginas nuevas.</li>
index d3a9f13..f96e205 100644 (file)
@@ -27,7 +27,7 @@
 
     <body>
         <h3>2.7 (código de versión 27)</h3>
-        <p>7 de noviembre de 2017 - API mínimo 19, API dirigido 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7 de noviembre de 2017</a> - API mínimo 19, API dirigido 26</p>
         <ul>
             <li>Añadir un <a href="https://redmine.stoutner.com/issues/132">cajón de favoritos</a> al que se accede deslizando desde la derecha.</li>
             <li>Evitar que el Modo Noche <a href="https://redmine.stoutner.com/issues/213">parpadee sobre un fondo blanco</a> al cargar páginas nuevas.</li>
index 80f4837..6c6eb99 100644 (file)
@@ -27,7 +27,7 @@
 
     <body>
         <h3>2.7 (version code 27)</h3>
-        <p>7 Novembre 2017 - minima API 19, target API 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7 Novembre 2017</a> - minima API 19, target API 26</p>
         <ul>
             <li>Aggiunta di un <a href="https://redmine.stoutner.com/issues/132">cassetto dei segnalibri</a> accessibile scorrendo da destra.</li>
             <li>Corretto un difetto della Modalità Notte per cui appariva <a href="https://redmine.stoutner.com/issues/213">uno sfondo bianco</a> durante il caricamento di pagine nuove.</li>
index ee1715e..16e11eb 100644 (file)
@@ -27,7 +27,7 @@
 
     <body>
         <h3>2.7 (version code 27)</h3>
-        <p>7 Novembre 2017 - minima API 19, target API 26</p>
+        <p><a href="https://git.stoutner.com/?p=PrivacyBrowser.git;a=commitdiff;h=eb9bc527c37223964f7c00592df982b47ff2f81c">7 Novembre 2017</a> - minima API 19, target API 26</p>
         <ul>
             <li>Aggiunta di un <a href="https://redmine.stoutner.com/issues/132">cassetto dei segnalibri</a> accessibile scorrendo da destra.</li>
             <li>Corretto un difetto della Modalità Notte per cui appariva <a href="https://redmine.stoutner.com/issues/213">uno sfondo bianco</a> durante il caricamento di pagine nuove.</li>
index dae2ca4..bec0b3a 100644 (file)
@@ -21,5 +21,5 @@
 <!-- Highlight the selected item when the spinner is open. -->
 <selector xmlns:android="http://schemas.android.com/apk/res/android" >
     <item android:state_checked="true" android:color="@color/gray_300" />
-    <item android:color="@color/gray_500" />
+    <item android:color="@color/blue_300" />
 </selector>
\ No newline at end of file
index 6df2333..5175182 100644 (file)
@@ -20,7 +20,6 @@
 
 <!-- Change the dark theme enabled text from white to gray. -->
 <selector xmlns:android="http://schemas.android.com/apk/res/android" >
-    <!-- `#4DFFFFFF` comes from the built-in `@color/primary_text_disabled_material_dark`. -->
-    <item android:state_checked="false" android:color="#4DFFFFFF" />
+    <item android:state_checked="false" android:color="@color/gray_500" />
     <item android:color="@color/gray_300" />
 </selector>
\ No newline at end of file
index 73c8e5d..b113ca7 100644 (file)
                 android:layout_marginTop="14dp"
                 android:layout_marginBottom="14dp"
                 android:text="@string/javascript_enabled"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:textSize="18sp" />
         </LinearLayout>
 
                 android:layout_marginTop="14dp"
                 android:layout_marginBottom="14dp"
                 android:text="@string/first_party_cookies_enabled"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:textSize="18sp" />
         </LinearLayout>
 
                 android:layout_marginTop="14dp"
                 android:layout_marginBottom="14dp"
                 android:text="@string/third_party_cookies_enabled"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:textSize="18sp" />
         </LinearLayout>
 
                 android:layout_marginTop="14dp"
                 android:layout_marginBottom="14dp"
                 android:text="@string/dom_storage_enabled"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:textSize="18sp" />
         </LinearLayout>
 
                 android:layout_marginTop="14dp"
                 android:layout_marginBottom="14dp"
                 android:text="@string/form_data_enabled"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:textSize="18sp" />
         </LinearLayout>
 
                     android:layout_width="match_parent"
                     android:layout_marginStart="8dp"
                     android:text="@string/pinned_ssl_certificate"
-                    android:textColor="?attr/primaryTextColorSelector"
+                    android:textColor="?android:textColorPrimary"
                     android:textSize="18sp" />
             </LinearLayout>
 
index bef27af..6d746b6 100644 (file)
@@ -31,5 +31,4 @@
     android:paddingTop="8dp"
     android:paddingBottom="8dp"
     android:textSize="18sp"
-    android:textColor="?attr/primaryTextColorSelector"
     android:checkMark="?android:attr/listChoiceIndicatorSingle" />
\ No newline at end of file
index d06d7cf..0896cff 100644 (file)
@@ -28,4 +28,4 @@
     android:paddingStart="10dp"
     android:paddingEnd="10dp"
     android:textSize="18sp"
-    android:textColor="?attr/primaryTextColorSelector" />
\ No newline at end of file
+    android:textColor="?android:textColorPrimary" />
\ No newline at end of file
index 625b3ed..fa7ee1d 100644 (file)
@@ -46,7 +46,7 @@
                 android:layout_width="wrap_content"
                 android:text="@string/database_id"
                 android:textSize="18sp"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:layout_marginEnd="8dp" />
 
             <TextView
                     android:layout_marginBottom="4dp"
                     android:text="@string/current_bookmark_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
 
                 <RadioButton
                     android:id="@+id/edit_bookmark_webpage_favorite_icon_radiobutton"
                     android:layout_marginTop="5dp"
                     android:text="@string/web_page_favorite_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
             </RadioGroup>
         </LinearLayout>
 
                 android:layout_width="wrap_content"
                 android:text="@string/folder"
                 android:textSize="18sp"
-                android:textColor="?attr/primaryTextColorSelector" />
+                android:textColor="?android:textColorPrimary" />
 
             <Spinner
                 android:id="@+id/edit_bookmark_folder_spinner"
                 android:layout_width="wrap_content"
                 android:text="@string/display_order"
                 android:textSize="18sp"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:layout_marginEnd="6dp"
                 android:labelFor="@+id/edit_bookmark_display_order_edittext"/>
 
index d06d7cf..0896cff 100644 (file)
@@ -28,4 +28,4 @@
     android:paddingStart="10dp"
     android:paddingEnd="10dp"
     android:textSize="18sp"
-    android:textColor="?attr/primaryTextColorSelector" />
\ No newline at end of file
+    android:textColor="?android:textColorPrimary" />
\ No newline at end of file
index 5e7afdd..1184805 100644 (file)
@@ -75,7 +75,7 @@
                     android:layout_marginBottom="4dp"
                     android:text="@string/current_bookmark_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
 
                 <RadioButton
                     android:id="@+id/edit_bookmark_webpage_favorite_icon_radiobutton"
@@ -84,7 +84,7 @@
                     android:layout_marginTop="5dp"
                     android:text="@string/web_page_favorite_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
             </RadioGroup>
         </LinearLayout>
 
index 72acc7e..6ea35ee 100644 (file)
@@ -46,7 +46,7 @@
                 android:layout_width="wrap_content"
                 android:text="@string/database_id"
                 android:textSize="18sp"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:layout_marginEnd="8dp" />
 
             <TextView
                     android:layout_marginBottom="4dp"
                     android:text="@string/current_bookmark_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
 
                 <RadioButton
                     android:id="@+id/edit_folder_default_icon_radiobutton"
                     android:layout_marginBottom="4dp"
                     android:text="@string/default_folder_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
 
                 <RadioButton
                     android:id="@+id/edit_folder_webpage_favorite_icon_radiobutton"
                     android:layout_marginTop="5dp"
                     android:text="@string/web_page_favorite_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
             </RadioGroup>
         </LinearLayout>
 
                 android:layout_width="wrap_content"
                 android:text="@string/parent_folder"
                 android:textSize="18sp"
-                android:textColor="?attr/primaryTextColorSelector" />
+                android:textColor="?android:textColorPrimary" />
 
             <Spinner
                 android:id="@+id/edit_folder_parent_folder_spinner"
                 android:layout_width="wrap_content"
                 android:text="@string/display_order"
                 android:textSize="18sp"
-                android:textColor="?attr/primaryTextColorSelector"
+                android:textColor="?android:textColorPrimary"
                 android:layout_marginEnd="6dp"
                 android:labelFor="@+id/edit_folder_display_order_edittext"/>
 
index 8b1f587..9bed6a4 100644 (file)
@@ -87,7 +87,7 @@
                     android:layout_marginBottom="4dp"
                     android:text="@string/current_folder_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
 
                 <RadioButton
                     android:id="@+id/edit_folder_default_icon_radiobutton"
@@ -97,7 +97,7 @@
                     android:layout_marginBottom="4dp"
                     android:text="@string/default_folder_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
 
                 <RadioButton
                     android:id="@+id/edit_folder_web_page_icon_radiobutton"
                     android:layout_marginTop="5dp"
                     android:text="@string/web_page_favorite_icon"
                     android:textSize="18sp"
-                    android:textColor="?attr/primaryTextColorSelector" />
+                    android:textColor="?android:textColorPrimary" />
             </RadioGroup>
         </LinearLayout>
 
index 72e4c3e..e6544ce 100644 (file)
@@ -31,7 +31,6 @@
     <attr name="sslTitle" format="reference" />
     <attr name="sslHeader" format="reference" />
     <attr name="urlHistoryText" format="reference" />
-    <attr name="primaryTextColorSelector" format="reference" />
     <attr name="bookmarksSpinnerHeaderTextColor" format="reference" />
     <attr name="bookmarksSpinnerTextColorSelector" format="reference" />
     <attr name="bookmarksSpinnerBackground" format="reference" />
index 343ceba..8f9c593 100644 (file)
@@ -24,6 +24,7 @@
     <!-- `android:windowTranslucentStatus` makes the system status bar translucent.  When it is specified the root layout should include `android:fitsSystemWindows="true"`. -->
     <style name="PrivacyBrowserLight" parent="Theme.AppCompat.Light.NoActionBar" >
         <item name="android:windowTranslucentStatus">true</item>
+        <item name="android:textColorPrimary">@color/primary_text_color_selector_light</item>
         <item name="colorAccent">@color/blue_700</item>
         <item name="android:textColorHighlight">@color/blue_200</item>
         <item name="navigationHeaderBackground">@color/blue_700</item>
@@ -45,7 +46,6 @@
         <item name="colorPrimaryDark">@color/blue_700</item>
         <item name="android:textColorHighlight">@color/blue_200</item>
         <item name="android:actionModeBackground">@color/blue_700</item>
-        <item name="primaryTextColorSelector">@color/primary_text_color_selector_light</item>
         <item name="bookmarksSpinnerHeaderTextColor">@color/white</item>
         <item name="bookmarksSpinnerTextColorSelector">@color/bookmarks_spinner_color_selector_light</item>
         <item name="bookmarksSpinnerBackground">@color/blue_750</item>
         <item name="windowActionModeOverlay">true</item>
         <item name="colorPrimaryDark">@color/blue_800</item>
         <item name="android:actionModeBackground">@color/blue_800</item>
-        <item name="primaryTextColorSelector">@color/primary_text_color_selector_dark</item>
         <item name="bookmarksSpinnerHeaderTextColor">@color/gray_300</item>
         <item name="bookmarksSpinnerTextColorSelector">@color/bookmarks_spinner_color_selector_dark</item>
         <item name="bookmarksSpinnerBackground">@color/blue_830</item>